refactor code

access_unix.go

@@ -4,6 +4,6 @@ package adb
 
 import "golang.org/x/sys/unix"
 
-func access(path string) error {
+func isExecutableOnPlatform(path string) error {
 	return unix.Access(path, unix.X_OK)
 }

access_win.go

@@ -7,8 +7,9 @@ import (
 	"strings"
 )
 
-func access(path string) error {
+func isExecutableOnPlatform(path string) error {
-	if strings.Contains(path, ".exe") {
+	if strings.HasSuffix(path, ".exe") || strings.HasSuffix(path, ".cmd") ||
+		strings.HasSuffix(path, ".bat") {
 		return nil
 	}
 	return errors.New("not an executable")

server.go

@@ -136,7 +136,7 @@ var localFilesystem = &filesystem{
 		if !info.Mode().IsRegular() {
 			return stderrors.New("not a regular file")
 		}
-		return Access(path)
+		return isExecutable(path)
 	},
 	CmdCombinedOutput: func(name string, arg ...string) ([]byte, error) {
 		return exec.Command(name, arg...).CombinedOutput()

unix.go

@@ -1,11 +1,11 @@
 package adb
 
 /*
-Exported Access function calls private access function.
+isExecutable function calls the isExecutableOnPlatform function.
-Implementation for private access function is provided in
+Implementation the isExecutableOnPlatform function is provided in
-access_win.go for windows and
+execuatble_win.go for windows and
-access_unix.go for unix
+executable_unix.go for unix.
 */
-func Access(path string) error {
+func isExecutable(path string) error {
-	return access(path)
+	return isExecutableOnPlatform(path)
 }